Skip to content

[fix][backend]: archive option tag#199

Merged
SharkeyChen merged 1 commit into
mainfrom
fix/archive_tag
Sep 22, 2025
Merged

[fix][backend]: archive option tag#199
SharkeyChen merged 1 commit into
mainfrom
fix/archive_tag

Conversation

@SharkeyChen
Copy link
Copy Markdown
Collaborator

@SharkeyChen SharkeyChen commented Sep 22, 2025 •
edited
Loading

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: update createdAt & createdBy when archiving option tag
zh(optional):

(Optional) Which issue(s) this PR fixes:

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 22, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   58.81%   61.55%   +2.74%     
==========================================
  Files         512      470      -42     
  Lines       53303    49971    -3332     
==========================================
- Hits        31352    30762     -590     
+ Misses      19570    16939    -2631     
+ Partials     2381     2270     -111
Flag Coverage Δ
unittests 61.55% <100.00%> (+2.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/data/application/tag_app.go 38.84% <ø> (ø)
...odules/data/domain/tag/service/tag_service_impl.go 90.76% <100.00%> (-0.02%) ⬇️

... and 50 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b477e7f...eb690bb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SharkeyChen SharkeyChen merged commit 512556a into main Sep 22, 2025
18 of 20 checks passed
@SharkeyChen SharkeyChen deleted the fix/archive_tag branch September 22, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsy357 lsy357 lsy357 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SharkeyChen @CLAassistant @lsy357